Error in general-template.php

[johannesjo]

The use of (string) is cause of an error to me with php 5.4. Also the documentation of the function is in conflict with the comparison at the beginning of the function, where helper is expected to be a mixed-var-type:

/**
 * Private helper function for checked, selected, and disabled.
 *
 * Compares the first two arguments and if identical marks as $type
 *
 * @since 2.8.0
 * @access private
 *
 * @param mixed $helper One of the values to compare
 * @param mixed $current (true) The other value to compare if not just true
 * @param bool $echo Whether to echo or just return the string
 * @param string $type The type of checked|selected|disabled we are doing
 * @return string html attribute or empty string
 */
function __checked_selected_helper( $helper, $current, $echo, $type ) {
	if ( (string) $helper === (string) $current )

[ocean90]

Hello johannesjo,

can you please post the exact error message?

[SergeyBiryukov]

Could you provide a piece of code to reproduce the issue?

[wonderboymusic]

@johannesjo, reopen if you have steps to reproduce.