EOL of wp-config-sample is now somehow set to LF

[tai]

EOL of wp-config-sample.php in the latest, 3.9.1 is now somehow set to LF.
Suppose to be CRLF. Please see #12775.

[nacin]

Hi tai, it appears to be LF for me. Is this for a localized build of WordPress, or the English zip from wordpress.org/latest.zip?

[tai]

Hi nacin, it is for the English one.
I've downloaded it from ​http://wordpress.org/latest.zip and found it is set to LF.
Our Japanese version's EOL is set to CRLF.
Should be CRLF, right?

[tai]

FYI:
EOL of
​https://develop.svn.wordpress.org/tags/3.9.1/wp-config-sample.php
is set to CRLF, but the one of
​http://core.svn.wordpress.org/tags/3.9.1/wp-config-sample.php
is set to LF.

[SergeyBiryukov]

Replying to tai:

EOL of ​https://develop.svn.wordpress.org/tags/3.9.1/wp-config-sample.php is set to CRLF,
but the one of ​http://core.svn.wordpress.org/tags/3.9.1/wp-config-sample.php is set to LF.

Confirmed. This appears to be an unintentional change between 3.7 and 3.8, when ​develop.svn.wordpress.org and build.trac.wordpress.org were introduced:

​https://build.trac.wordpress.org/browser/tags/3.7/wp-config-sample.php (svn:eol-style set to CRLF)
​https://build.trac.wordpress.org/browser/tags/3.8/wp-config-sample.php (svn:eol-style set to native)

Seems to be changed with ​https://build.trac.wordpress.org/browser/trunk/wp-config-sample.php?rev=25861.

See [2370] and [5457] for the original commits (svn:eol-style changed from native to CRLF).

@dd32, @ocean90: Should this be fixed in ​https://core.svn.wordpress.org/?

[dd32]

Confirmed, this is because our sync script doesn't appear to copy over properties.

I've fixed it up for the 4.4 branch and trunk in ​https://build.trac.wordpress.org/changeset/35925 but I'm not sure if that'll stick around or if it'll be lost in the next develop -> core sync.

[dd32]

Looks like the properties were lost because of ​https://build.trac.wordpress.org/changeset/25860/ which caused a svn rm and a svn add on the following commit.

Now that I've fixed these, I'm fairly certain it'll stay around until an accidental deletion comes along again.

To be super safe, we could also add a svn propset svn:eol-style CRLF wp-config-sample.php license.txt to the svn sync script (FYI @nacin)

[dd32]

I'm going to mark this as fixed, the file in question has been CRLF'd for 4 years.