WordPress.org

Make WordPress Core

Opened 6 years ago

Last modified 8 months ago

#28188 new enhancement

Make Natively-Outputted .widget_rss CSS Selector HTML5-Appropriate

Reported by: EMG Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: Widgets Keywords: needs-patch
Focuses: template Cc:
PR Number:

Description

In regards to the natively outputted RSS Widget entitled .widget_rss, the post Author's name is currently outputted as wrapped in a <cite> tag.

An example of a natively outputted RSS feed block looks something like this for reference:

<a class='rsswidget' href='http://blah.net/2014/04/14/blahblah/'>Example RSSed Post</a> <span class="rss-date">April 14, 2014</span> <div class="rssSummary">This is the space where the RSSed information appears. […]</div> <cite>Author</cite>

Please note that the author of the RSSed post is being natively outputted as wrapped in the <cite> tag.

As per #27944 (ocean90's comment in particular) which references #24522 (re: proper way to tag comment authors), the natively outputted CSS selectors for the .widget_rss widget probably ought to be wrapped in something like: <span class="comment-author"> as opposed to <cite>.

Reiterating what ocean90 said: The <cite> tag is supposed to be used for a cited block of text (like a citation) rather than used to tag the/an author.

Additionally, changing the <cite> to <span class="comment-author"> will provide additional sitewide code uniformity (there's a word or phrase I am looking for and I can't remember it!) for a natively/vanilla outputted WordPress site (and especially if using a default WordPress theme) re: how author names are wrapped in tags.

Thanks!

Change History (4)

#1 follow-up: @ocean90
6 years ago

  • Focuses template added

We have to be careful here, because this will break backwards compatibility.

Thinking out loud: Maybe we can introduce add_theme_support( 'html5', array( 'widgets') ).

#2 in reply to: ↑ 1 ; follow-up: @EMG
6 years ago

Replying to ocean90:

We have to be careful here, because this will break backwards compatibility.

Thinking out loud: Maybe we can introduce add_theme_support( 'html5', array( 'widgets') ).

Totally didn't realize that when I created the ticket - oh boy. :(

Was #27944 an easier fix because it wasn't originally wrapped in tags to begin with and so it would essentially be a 'new feature' going forward?

#3 in reply to: ↑ 2 @ocean90
6 years ago

Replying to EMG:

Was #27944 an easier fix because it wasn't originally wrapped in tags to begin with and so it would essentially be a 'new feature' going forward?

Correct.

#4 @chriscct7
4 years ago

  • Keywords needs-patch added
Note: See TracTickets for help on using tickets.