WordPress.org

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2821 closed defect (bug) (fixed)

RBL used for comment spam check gone

Reported by: jabesse Owned by: Nazgul
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0.3
Component: General Keywords: comment spam rbl bg|has-patch bg|2nd-opinion
Focuses: Cc:

Description

In WP 2.0.3, there is an option to check for open proxies. This is implemented with an RBL check at opm.blitzed.org. However, this RBL is now gone: http://lists.blitzed.org/pipermail/opm-announce/2006q2.txt

Blitzed should be replaced. I suggest spamhaus: sbl-xbl.spamhaus.org

Attachments (4)

2821_203.diff (556 bytes) - added by Nazgul 14 years ago.
2821_svn.diff (2.1 KB) - added by Nazgul 14 years ago.
2821_offbydefault_203.diff (484 bytes) - added by Nazgul 14 years ago.
2821_offbydefault_svn.diff (484 bytes) - added by Nazgul 14 years ago.

Download all attachments as: .zip

Change History (13)

#1 @jabesse
14 years ago

  • Milestone set to 2.0.4

#2 @evilzenscientist
14 years ago

Any chance of making this an editable; multi-valued entry?

Obviously some UI impact - so maybe a 2.1 milestone.

Justification for this:

  • regional preferences (keep traffic local within geo)
  • spread the load across multiple RBL check services

@Nazgul
14 years ago

@Nazgul
14 years ago

#3 @Nazgul
14 years ago

  • Keywords bg|has-patch bg|2nd-opinion added
  • Version changed from 2.0.2 to 2.0.3

I've created 2 patches for this.

One based on 2.0.3, which just replaces the old opm.blitzed.org to the suggested sbl-xbl.spamhaus.org.

The second one is based on trunk and utilizes a new option called open_proxy_check_url, which contains sbl-xbl.spamhaus.org by default. This allows plug-ins to change this value if needed, without having to wait for a new official release.

Maybe the second option could also be used for the 2.0.4 release, but I'm not entirely comfortable in changing this behaviour in a bug-fix release. What do you guys think?

#4 @matt
14 years ago

  • Milestone changed from 2.0.4 to 2.1

The first patch sounds good, and maybe we should change this to be off by default.

#5 @markjaquith
14 years ago

+1 for off by default

#6 @jabesse
14 years ago

Off by default: as sbl-xbl.spamhaus.org lists quite some hosts, there is some risk of false positives. Therefor: +1 for off by default. (And some documentation about it?)

#7 @Nazgul
14 years ago

  • Owner changed from anonymous to Nazgul
  • Status changed from new to assigned

Added 'off by default' patches for both 2.0.x and 2.1. These can be used in addition to the blitzed to spamhaus switch.

#8 @ryan
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3959]) Update RBL site and turn open proxy check off by default. Props Nazgul. fixes #2821

#9 @ryan
14 years ago

(In [3960]) Update RBL site and turn open proxy check off by default. Props Nazgul. fixes #2821

Note: See TracTickets for help on using tickets.