WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#28225 closed defect (bug) (fixed)

Twenty Thirteen: Add accessibility-ready tag

Reported by: obenland Owned by: BODA1982
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.6
Component: Bundled Theme Keywords: good-first-bug has-patch commit
Focuses: accessibility Cc:
PR Number:

Description (last modified by Otto42)

Twenty Thirteen had an extensive accessibility review throughout its development, yet at the time we didn't have a proper tag to tag it with. Now that we do, and since it is also searchable on the theme showcase, we should add it.

Related: #meta348, #26157.

Attachments (2)

style.diff (1.0 KB) - added by BODA1982 6 years ago.
Added "accessibility-ready" tag to twentythirteen stylesheet.
28225.diff (1.1 KB) - added by BODA1982 6 years ago.
Updated twentythirteen stylesheet to include accessibility-ready tag

Download all attachments as: .zip

Change History (10)

#1 @Otto42
6 years ago

  • Description modified (diff)

@BODA1982
6 years ago

Added "accessibility-ready" tag to twentythirteen stylesheet.

#2 @BODA1982
6 years ago

Diff submitted. This is my first contribution, so if I have left something out please let me know. Obviously an easy ticket, but feedback always welcome.

#3 @DrewAPicture
6 years ago

  • Keywords has-patch commit added
  • Milestone changed from Future Release to 4.0

Hi BODA1982, your patch looks great. One thing, in the future you'll want to make sure to generate patches from the WordPress root, but nice work nonetheless!

#4 @DrewAPicture
6 years ago

  • Owner set to BODA1982
  • Status changed from new to assigned

#5 @BODA1982
6 years ago

Understood. Thanks!

#6 @lancewillett
6 years ago

Welcome BODA1982 and thanks for the patch. Another very minor note for next time, our convention is to name the patch after the Trac ticket number. So in this case "28225.diff" — this helps a lot for other contributors that have a ton of patches floating around. :)

@BODA1982
6 years ago

Updated twentythirteen stylesheet to include accessibility-ready tag

#7 @BODA1982
6 years ago

Understood. I went ahead and submitted a new diff containing updates with both of the feedback provided (diff from wp-root and file name).

#8 @lancewillett
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 28395:

Twenty Thirteen: add accessibility-ready tag. Fixes #28225, props BODA1982.

Note: See TracTickets for help on using tickets.