Opened 10 years ago
Closed 5 years ago
#28239 closed enhancement (fixed)
Unify size format display
Reported by: | johnbillion | Owned by: | pento |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | 2.3 |
Component: | Formatting | Keywords: | has-patch |
Focuses: | Cc: |
Description
#25643 replaced a couple of buggy blocks of code with calls to size_format()
.
There are some other places where we can use size_format()
instead of manually constructing strings with file size units in them.
Patch coming up.
Attachments (1)
Change History (7)
#2
@
10 years ago
One problem here is that get_space_allowed()
(used by display_space_usage()
) retrieves the space allowed in megabytes, whereas size_format()
converts a given number of bytes.
So in order to get this to work, we need to multiply the given figure by 1 million (roughly), which feels a bit hackish.
Or we could change the way get_space_allowed()
works, but that's tied into the mu blog option: blog_upload_space
, which is also in megabytes.
#3
@
10 years ago
- Milestone changed from 4.0 to Future Release
No patch, punting. johnbillion, not sure if you still have a patch lying around.
#5
@
5 years ago
- Keywords has-patch added; needs-patch removed
- Milestone set to 5.3
- Owner set to pento
- Status changed from new to assigned
28239.diff changes display_space_usage()
to use size_format()
.
Looks like only
display_space_usage()
- let's patch it up