WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#28249 closed enhancement (fixed)

Sandbox embeds in an <iframe> for loading preview in TinyMCE

Reported by: wonderboymusic's profile wonderboymusic Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Embeds Keywords: close
Focuses: Cc:

Description

An alternate approach to #28195.

Change History (8)

This ticket was mentioned in IRC in #wordpress-dev by wonderboymusic. ​View the logs.
10 years ago

#2 @danielbachhuber
10 years ago

iframes work great — I've used this approach on a client project. Basically, the iframe made a request to admin-ajax.php, admin-ajax rendered the embed, and the iframe communicated back to TinyMCE its height and width.

This ticket was mentioned in IRC in #wordpress-dev by helen. ​View the logs.
10 years ago

This ticket was mentioned in IRC in #wordpress-dev by helen. ​View the logs.
10 years ago

#5 @iseulde
10 years ago

  • Keywords close added

Is it okay to close this?

#6 @helen
10 years ago

Did we fix it via a changeset, or is it invalid now?

#7 @iseulde
10 years ago

Anything with a script will be sandboxed since [28748].

#8 @azaozz
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Should have mentioned this ticket in [28748], sry. The sandboxing seems to work well. Closing as fixed, feel free to reopen if any bugs.

Note: See TracTickets for help on using tickets.