WordPress.org

Make WordPress Core

#28249 closed enhancement (fixed)

Sandbox embeds in an <iframe> for loading preview in TinyMCE

Reported by: wonderboymusic Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Embeds Keywords: close
Focuses: Cc:

Description

An alternate approach to #28195.

Change History (8)

comment:1 @ircbot15 months ago

This ticket was mentioned in IRC in #wordpress-dev by wonderboymusic. View the logs.

comment:2 @danielbachhuber15 months ago

iframes work great — I've used this approach on a client project. Basically, the iframe made a request to admin-ajax.php, admin-ajax rendered the embed, and the iframe communicated back to TinyMCE its height and width.

comment:3 @ircbot14 months ago

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

comment:4 @ircbot13 months ago

This ticket was mentioned in IRC in #wordpress-dev by helen. View the logs.

comment:5 @iseulde13 months ago

  • Keywords close added

Is it okay to close this?

comment:6 @helen13 months ago

Did we fix it via a changeset, or is it invalid now?

comment:7 @iseulde13 months ago

Anything with a script will be sandboxed since [28748].

comment:8 @azaozz13 months ago

  • Resolution set to fixed
  • Status changed from new to closed

Should have mentioned this ticket in [28748], sry. The sandboxing seems to work well. Closing as fixed, feel free to reopen if any bugs.

Note: See TracTickets for help on using tickets.