WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#28262 closed defect (bug) (fixed)

Add styles for new HTML5 input elements and fix some style issues

Reported by: iseulde's profile iseulde Owned by: helen's profile helen
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: General Keywords: needs-patch
Focuses: ui, accessibility Cc:

Description

See screenshots.

Attachments (4)

forms.patch​ (8.0 KB) - added by iseulde 11 years ago.
forms-before.png​ (147.2 KB) - added by iseulde 11 years ago.
forms-after.png​ (147.5 KB) - added by iseulde 11 years ago.
28262.customizer.png​ (11.9 KB) - added by celloexpressions 10 years ago.
With patch, Customizer in Chrome with implicitly-supported control types.

Download all attachments as: .zip

Change History (17)

@iseulde
11 years ago

@iseulde
11 years ago

@iseulde
11 years ago

#1 @iseulde
11 years ago

  • Keywords has-patch added

Screenshots are made in with Firefox.

#2 @wonderboymusic
11 years ago

  • Milestone changed from Awaiting Review to 4.0

#3 @ocean90
10 years ago

avryl, are your screenshots from a plugin? Can you attach it to the ticket please?

#4 @iseulde
10 years ago

Kind of, I just made something a while ago to test some things and work on jQuery UI.
​https://github.com/avryl/ui

@celloexpressions
10 years ago

With patch, Customizer in Chrome with implicitly-supported control types.

#5 @celloexpressions
10 years ago

Patch works well in the Customizer; can use the test plugin on #28477 to test this patch there.

Probably ready for commit.

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. ​View the logs.
10 years ago

#7 @DrewAPicture
10 years ago

  • Keywords commit added

Patch still applies, looks good.

#8 @helen
10 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 29465:

Add styling for various HTML5 input elements. props avryl. fixes #28262.

#9 @johnbillion
10 years ago

  • Focuses accessibility added
  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

r29465 has broken the focus styles for checkboxes and radio buttons. Seen in Chrome 36 on OS X.

#10 @ocean90
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29519:

Restore focus styles for checkboxes and radio buttons. Broken since [29465].

fixes #28262.

#11 @miqrogroove
10 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Checkboxes now have two different styles.

forms.css:170 border: 1px solid #ddd;

overrides

forms.css:17 border: 1px solid #bbb;

If this change was intentional, I will also need to override it in my contrast plugin.

#12 @helen
10 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29604:

Correct cascade oversights in form CSS. fixes #28262.

#13 @helen
10 years ago

#27898 was marked as a duplicate.

Note: See TracTickets for help on using tickets.