WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#28265 closed enhancement (fixed)

Add OEmbed support for Animoto videos

Reported by: lritter Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch
Focuses: Cc:

Description

As a user, I'd like to simply embed videos created and hosted by Animoto. Wordpress.com-hosted sites already support this but ".org" does not yet.

Attachments (3)

add_animoto_oembed_support.diff (890 bytes) - added by lritter 7 years ago.
patch adding oembed support for animoto
28265.diff (902 bytes) - added by wonderboymusic 7 years ago.
28265.2.diff (1.0 KB) - added by kovshenin 7 years ago.

Download all attachments as: .zip

Change History (18)

@lritter
7 years ago

patch adding oembed support for animoto

#2 @johnbillion
7 years ago

  • Keywords reporter-feedback has-patch added

Animoto appears to be fairly well established.

@Iritter: could you provide some answers to the points in Sergey's link above please?

#3 in reply to: ↑ 1 @lritter
7 years ago

Replying to SergeyBiryukov:

For reference: http://make.wordpress.org/core/handbook/design-decisions/#whitelisting-oembed-providers

Is the service is popular enough for core developers to have heard of it before? Is it “mainstream?”

I don't know how to evaluate this but recent press indicates ~10m users.

If similar services are already supported, how does this service compare in terms of size, features, and backing?

Animoto is a simple tool for creating video from photos, music, and text. There is no equivalent tool supported right now.

Does this service have a large following on Twitter, Facebook, or other social media? Is its Twitter account verified?

@animoto is verified.

Is its oEmbed endpoint clearly established and properly documented? Sometimes, they are just a developer’s pet project that may not be supported.)

Documentation: http://help.animoto.com/entries/109992-oEmbed-API

Does the service make an effort to build relationships with developers, such as through robust APIs?

There are a number of integration options detailed here: http://animoto.com/developer

How old is the service?

Animoto is 7 years old.

Does it have a well-established Wikipedia article? (Seriously.)

I don't know what "well-established" means but here's the article: https://en.wikipedia.org/wiki/Animoto

Has anyone written a WordPress plugin that leverages the service in some way, whether adding it as an oEmbed provider, creating a shortcode, or leveraging other APIs of the service? Do these plugins have any noticeable adoption or traction that would indicate usage and demand?

Animoto wrote a plugin. I don't really know how to judge the "demand" aspect but apparently it was high enough to justify inclusion in wordpress.com.

Is the provider frequently proposed?

I don't have access to data to say either way.

#4 @lritter
7 years ago

  • Keywords reporter-feedback removed

#5 @wonderboymusic
7 years ago

  • Milestone changed from Awaiting Review to 4.0

Animoto has been around for a while, I first saw them present at a "Facebook Developers Garage" in NYC in 2008.

Followers (as with Issuu, way more than Viddler):
Facebook ~50K
Twitter 61.9K

Issuu had a couple of other core contributors chime in. If someone else agrees this should go in, it shall.

#6 follow-up: @johnbillion
7 years ago

  • Keywords reporter-feedback added

Iritter: What's the relevance of video214.com in your patch? Was this a mistake or is it also part of Animoto?

#7 in reply to: ↑ 6 @lritter
7 years ago

Replying to johnbillion:

Iritter: What's the relevance of video214.com in your patch? Was this a mistake or is it also part of Animoto?

Yes, video214.com is part of animoto. When some business users share their videos with their customers they use video214 to hide animoto branding.

@wonderboymusic
7 years ago

#8 @wonderboymusic
7 years ago

  • Keywords commit added; reporter-feedback removed

Updated the patch to optionally allow https and www. which redirect to the animoto.com domain.

I made a video here, they are really cool: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA

#9 @wonderboymusic
7 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28790:

Add Animoto to the list of oEmbed providers. Example video: http://animoto.com/play/MlRRgXHhoT8gOZyHanM6TA.

Props lritter.
Fixes #28265.

@kovshenin
7 years ago

#10 follow-up: @kovshenin
7 years ago

  • Keywords commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re r28790: one regex is faster than two. We can use (animoto|video214) and we also need to escape the . in .com. See 28265.2.diff.

#11 in reply to: ↑ 10 ; follow-up: @SergeyBiryukov
7 years ago

Replying to kovshenin:

Re r28790: one regex is faster than two.

Should we perhaps revert [28593] as well?

#12 in reply to: ↑ 11 @kovshenin
7 years ago

Replying to SergeyBiryukov: That change was for backwards compatibility reasons, though as Nacin mentioned in #28125, we've changed patterns before and will probably have a need to in the future. It'd be easier if these were keyed by unique handles, rather than regular expressions.

#13 @SergeyBiryukov
7 years ago

Well, if someone is using wp_oembed_remove_provider() to disallow YouTube embeds, they would have to make changes for playlists anyway, so I guess I'd prefer to merge those YouTube patterns too for consistency.

#14 @SergeyBiryukov
7 years ago

In 28822:

Merge two Animoto oEmbed patterns.

props kovshenin.
see #28265.

#15 @kovshenin
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

True, but at least their existing block for /watch would still be in place. I don't mind reverting r28593. Given that the array is keyed by the regex pattern, wp_oembed_remove_provider() seems pretty useless anyway :) Feel free to reopen #28125 and continue the discussion.

Note: See TracTickets for help on using tickets.