Make WordPress Core

Opened 11 years ago

Closed 4 days ago

#28273 closed defect (bug) (worksforme)

Multisite sites without a path redirect to signup page

Reported by: ipstenu's profile Ipstenu Owned by: chriscct7's profile chriscct7
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: Administration Keywords: has-patch needs-testing
Focuses: multisite Cc:

Description

From https://wordpress.org/support/topic/after-update-to-39-one-sub-site-directs-to-wp-signupphpnew?replies=4&view=all

Pre 3.9, WordPress would treat an empty 'path' variable for the site as a /

As of 3.9, this is no longer the case, and a blank path will act as if the site does not exist.

It's a simple fix in the admin section, but this is a regression from 3.8

Attachments (3)

28273.patch (686 bytes) - added by JPry 11 years ago.
28273-2.patch (1.9 KB) - added by JPry 11 years ago.
A more comprehensive patch
28273-alternate.patch (340 bytes) - added by JPry 11 years ago.
Alternate method of fixing the reported issue

Download all attachments as: .zip

Change History (8)

@JPry
11 years ago

#1 @JPry
11 years ago

  • Keywords has-patch needs-testing added

This ticket was mentioned in IRC in #wordpress-dev by JPry. View the logs.


11 years ago

@JPry
11 years ago

A more comprehensive patch

@JPry
11 years ago

Alternate method of fixing the reported issue

#3 @danielkanchev
11 years ago

This is not related to the sub-site issue but if a single WP site not part of a network has its "home" and "siteurl" set to 'NULL' (empty string) then the WP displays "Error establishing a database connection". Probably the fix for the sub-site issue should be a universal fix for this issue as well.

Last edited 11 years ago by danielkanchev (previous) (diff)

#4 @chriscct7
10 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to chriscct7
  • Status changed from new to reviewing

#5 @SirLouen
4 days ago

  • Resolution set to worksforme
  • Status changed from reviewing to closed

Looking at the support ticket that @Ipstenu is referencing

In network admin > sites > edit site > info
The second line is Path. There was nothing in the field for this site. For all sites working properly, there was a forward slash like so: /

This field doesn't exist anymore.

Going back to 3.9 there was this field https://github.com/WordPress/wordpress-develop/blob/3.9.0/src/wp-admin/network/site-info.php

This field was removed in 4.3, [32759]

It's true that if we manually remove nowadays the Path, it will break. We have to do this through database though, it's not straightforward to accomplish this (and undesirable to do so)

With the patch provided, the main site works, but when accessing Network Sites, it goes in a canonical loop

This report is weird because it has a modification date of 6 years ago, despite there has not been more discussion for 10 years. Probably a spam comment that was removed and altered the modification time.

For all these reasons, I would say that this has been already fixed, indirectly; hence I think it's safe to close this ticket now, as fixed: worksforme

Note: See TracTickets for help on using tickets.