DFW: escape key broken

[iseulde]

Two things are broken:

1. When the content is focussed (place your cursor in the content), pressing esc doesn't work. Adding a listener to the TinyMCE editor solves this.
2. When switching tabs in the browser (or removing focus from the document some other way), pressing esc doesn't work because the document isn't focussed. Adding a listener to the window instead solves this.

You can't namespace events outside jQuery and keeping it in one place is useless, so I removed it.
Used keyup rather than keydown because that will only fire once.

[SergeyBiryukov]

In 28443:

DFW: Properly handle Esc key when the content is focused or when switching browser tabs.

props avryl.
fixes #28279.

[azaozz]

This introduced a regression: when a modal is open (wpLink or media), Esc closes both the modal and DFW. Also, why remove the "namespace" from the jQuery event? This should probably go into the coding standards: all jQuery events *must* be namespaced. That adds another level of interoperability.

[iseulde]

This introduced a regression: when a modal is open (wpLink or media), Esc closes both the modal and DFW.

It looks like this also happens in 3.9. But let's fix it. :)

Also, why remove the "namespace" from the jQuery event? This should probably go into the coding standards: all jQuery events *must* be namespaced. That adds another level of interoperability.

Oh, sorry. So it doesn't matter that the other event can't be namespaced?

[azaozz]

Replying to avryl:

It looks like this also happens in 3.9. But let's fix it. :)

Seems to work well without that commit. At least for the wpLink and media modals.

So it doesn't matter that the other event can't be namespaced?

Well, TinyMCE is different. Doesn't mean we should treat jQuery the same :)

In this case it's most likely the event may need unbinding outside the editor to tweak closing modals.

[iseulde]

Seems to work well without that commit. At least for the wpLink and media modals.

Weird, in 3.9 I enable DFW, open the media modal, press esc and everything closes.

[azaozz]

In [28455]:

DFW: fix closing only the wpLink or media modal when pressing Esc.

[SergeyBiryukov]

Looks like this was fixed in [28455].