Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 12 years ago

Closed 12 years ago

#28313 closed defect (bug) (fixed)

wpviews: selecting a view can add an undo level

Reported by:	iseulde	Owned by:	azaozz
Priority:	normal	Milestone:	4.0
Component:	TinyMCE	Version:	3.9
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

That's because of the class="selected" added to the wrap. If we use data-mce-selected="true" instead, it will be automatically removed by TinyMCE.

See: https://github.com/tinymce/tinymce/blob/master/js/tinymce/classes/UndoManager.js#L25

Attachments (1)

28313.patch (2.0 KB ) - added by iseulde 12 years ago.

Download all attachments as: .zip

Change History (4)

@iseulde
12 years ago

Attachment 28313.patch added

#1 @iseulde
12 years ago

Keywords has-patch added

#2 @gcorne
12 years ago

Milestone Awaiting Review → 4.0

#3 @azaozz
12 years ago

Owner set to azaozz
Resolution → fixed
Status new → closed

wpView: use data-mce-selected instead of adding a class to mark a view as selected. This prevents adding an unneeded undo level. Props avryl, fixes #28313

Note: See TracTickets for help on using tickets.

Download in other formats: