More tag can't be inserted if inside div

[programmin]

When content is inside a div tag, clicking the "more" icon just adds more after the div it was inserted in.

I don't remember this ever happening before 3.9, it's a major UI problem that it doesn't get added where your cursor is, but far below it.

This happens no matter the theme, I tried in Twenty Thirteen and 2 others.

[SergeyBiryukov]

Confirmed. Doesn't happen in 3.8.x.

[ebinnion]

Confirmed that something similar to the described behavior happened in trunk when the following content was in the text tab.

<div>

hello world

&nbsp;

&nbsp;

&nbsp;

&nbsp;

&nbsp;

&nbsp;

</div>

When switching back to the editor, if I clicked the more button when the cursor was directly beside 'hello world', the more shortcode was added at the bottom of the div. Which, in this case, is considerably further down the page from the 'hello world'.

I am attaching a patch that fixes the behavior and, in my opinion, simplifies some of the code.

Note: This patch only addresses /wp-includes/js/tinymce/plugins/wordpress/plugin.js and not any of the minified versions.

[DrewAPicture]

28335.diff​ refreshes the patch and fixes the issue as described.

[iseulde]

So what will now happen when you select a wpview and insert a more tag? Or if you set your cursor before or after it? What will happen when you insert a more tag when the cursor is inside some bold text, or some other inline element? As far as I can see, it will break the html...

I think we'll first need to use an inline placeholder for the tag, so it can be inserted anywhere.

[azaozz]

The <!--more--> tag is a "logical separator" of the content. Ideally it should go at the end of a paragraph that is a direct child of the body, and that is how most people use it. It's not (well) supported in other contexts, like in table, blockquote, pre, etc. Currently we are avoiding broken html by inserting it after the current block tag.

Was thinking to replace it inside the editor with <hr> element instead of the current <img>. That would make the placement a bit better and produce a bit cleaner html when "more" is inserted in an arbitrary place.

[bordoni]

Replying to azaozz:
I like this approach. Would allow people to give it style easier.

[azaozz]

Anybody wants to try replacing the placeholder <img> with a placeholder <hr> for 4.0? It's mostly CSS and a little JS :)

[DrewAPicture]

Sounds like we still need a patch here, see comment:7. Any takers?

[iseulde]

Too late for 4.0... These tags also have to be direct children of the body, so I think this is a wontfix.

[programmin]

Why must the more tag be a child of body? Is Wordpress not going to be doing force_balance_tags on excerpts anymore?

[mycota]

Is it wise to replace the <img> with just an <hr>, considering the image is descriptive and has text indicating what it does?

[iseulde]

Is it wise to replace the <img> with just an <hr>, considering the image is descriptive and has text indicating what it does?

We can use :before and :after to add some text. Moving to #29804.

Why must the more tag be a child of body? Is Wordpress not going to be doing force_balance_tags on excerpts anymore?

Because it's better if we don't have to. force_balance_tags doesn't really work well. <!--more--> is kind of meant to include some extra html such as an image, table or shortcode in the excerpt.