WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#28340 closed defect (bug) (fixed)

Twenty Fourteen: Non-empty hashtag assumed

Reported by: nabil_kadimi's profile nabil_kadimi Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: javascript Cc:

Description

The error appears in the browser Javascript console: 

Empty string passed to getElementById().

To reproduce:

  1. Activate Twenty fourteen
  2. Show a menu with a link whose URL is #
  3. Go to the site and click that link and notice the error in your browser console.

Attachments (2)

28340.patch​ (712 bytes) - added by nabil_kadimi 11 years ago.
Patch
28340.2.patch​ (784 bytes) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (6)

@nabil_kadimi
11 years ago

Patch

#1 @nabil_kadimi
11 years ago

  • Summary changed from Non-empty hashtag assumed to Non-empty hashtag assumed in Twentyfourteen

#2 @SergeyBiryukov
11 years ago

  • Component changed from General to Bundled Theme
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.0
  • Summary changed from Non-empty hashtag assumed in Twentyfourteen to Twenty Fourteen: Non-empty hashtag assumed

@SergeyBiryukov
11 years ago

#3 @SergeyBiryukov
11 years ago

  • Keywords commit added

I could not reproduce the error message in Firefox or Chrome, but the fix looks proper.

28340.2.patch​ makes it a bit more consistent with the surrounding code.

Last edited 11 years ago by SergeyBiryukov (previous) (diff)

#4 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28598:

Twenty Fourteen: Avoid passing an empty string to document.getElementById().

props nabil_kadimi.
fixes #28340.

Note: See TracTickets for help on using tickets.