Opened 10 years ago
Closed 10 years ago
#28346 closed defect (bug) (fixed)
Deprecated notice for get_current_site_name() does not mention its alternative
Reported by: | jesin | Owned by: | |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 3.9 |
Component: | General | Keywords: | has-patch commit |
Focuses: | docs, multisite | Cc: |
Description
Using get_current_site_name()
displays the following PHP notice.
get_current_site_name is deprecated since version 3.9 with no alternative available.
But the alternative for this function is get_current_site()
and the codex clearly mentions this.
Attachments (3)
Change History (10)
#2
follow-up:
↓ 3
@
10 years ago
- Keywords has-patch added
Hi Kim,
I have done that. But I find many functions in deprecated.php, ms-deprecated.php and pluggable-deprecated.php have two @deprecated tags.
#3
in reply to:
↑ 2
@
10 years ago
- Focuses docs added
Replying to jesin:
I have done that. But I find many functions in deprecated.php, ms-deprecated.php and pluggable-deprecated.php have two @deprecated tags.
Thanks for the new patch.
Most of the functions in those files were moved there (and the @deprecated tags added) before the inline docs standard was written last year. Those blocks have not been updated to the new standard.
I'll add this issue to our agenda for discussion at this week's Inline Docs meeting.
#5
@
10 years ago
- Keywords commit added
28346.2.diff looks good.
@jesin: Don't worry about fixing the older deprecated tags here. If we decide to update them, we'll do them all at once at a future date.
Hi Jesin, thanks for the patch!
Quick note on the docs - there should only be one @deprecated tag in the block. Could you change the line to the following, and submit a new patch please?
* @deprecated 3.9.0 Use get_current_site() instead.