"View Post" buttons for drafts not consistent

[mordauk]

When a post is saved as a draft, the main publish box shows a "Preview" button. The URL for the preview button is http://site.com/?p=149&preview=true.

Next to the post's permalink, however, is a "View" button. The URL for this button is http://site.com/?p=149 and is missing the &preview=true parameter.

Also in the toolbar is a "View" button that's identical to the "View" button next to the permalink. It also has a URL of http://site.com/?p=149.

Since the post is a draft, it seems logical that all of the buttons should all be "Preview" or "Preview Post" and should all have the &preview=true parameter.

Having the buttons next to the permalink and the toolbar show "View Post" is just confusing when the post is a draft. I've caught myself several times thinking "oh, did I publish this by accident?" when seeing the "View Post" buttons.

​https://cloudup.com/cuavhdeBxl1

[SergeyBiryukov]

The docblock should just be /** This filter is documented in wp-admin/includes/meta-boxes.php */.

[mordauk]

Patch with updated doc block

[mordauk]

Replying to SergeyBiryukov:

The docblock should just be /** This filter is documented in wp-admin/includes/meta-boxes.php */.

Aha! I was wondering what the proper method was for that, thanks! Updated patch attached.

[mordauk]

Updates View link in tool bar

[mordauk]

28350-3.patch updates the tool bar to show Preview instead of View if the current item is a draft and the current user can read it.

[SergeyBiryukov]

28350.4.patch​ uses a consistent target for all three links to avoid opening multiple tabs with the same preview.

[SergeyBiryukov]

In 28920:

Display consistent preview links for drafts.

props mordauk.
fixes #28350.

[SergeyBiryukov]

In 28947:

Simplify logic in get_sample_permalink_html(), remove duplicated code.

see #28350.

[SergeyBiryukov]

In 28947:

Simplify logic in get_sample_permalink_html(), remove duplicated code.

see #28350.

[SergeyBiryukov]

In 28948:

Simplify a condition in get_sample_permalink_html().

see #28350.

[nacin]

The standard "Preview Changes" button actually submits a form to ensure you are previewing the latest changes. This new "Preview" button does not do this, which is why it was always just "View Post".

[SergeyBiryukov]

Per IRC, the issue is that we have three preview links for drafts, only one of which actually previews the latest changes. The consensus is to still apply the preview_post_link filter for the other two links, but change the label back to "View Post".

[SergeyBiryukov]

In 29695:

Restore the post type's view_item label for preview links that don't submit the changes.

fixes #28350.

[nacin]

In 30410:

Revert [28948] for the 4.0 branch, which caused a regression.

see #29573 for 4.0. see #28350.

[SergeyBiryukov]

In 30791:

Revert [28948], which caused a regression.

see #29573 for trunk. see #28350.