WordPress.org

Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#28351 new enhancement

New filters in wp-signup.php

Reported by: UmeshSingla Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 3.0
Component: Login and Registration Keywords: has-patch
Focuses: multisite Cc:

Description

Added two new filters in wp-signup.php
confirm_user_signup and confirm_blog_signup, they allow a user to filter the message being printed on signup confirmation after successful user or blog registration.

Currently the wp-signup.php file does not provide enough flexibility to display a custom confirmation message, although it should be a easy thing.

Attachments (6)

wp-signup.patch (2.5 KB) - added by UmeshSingla 3 years ago.
Added filters to display a custom signup confirmation message for User or Blog registration
28351.diff (4.8 KB) - added by MikeHansenMe 3 years ago.
Updated based on previous patch but pass the original message into the filter
28351-2.diff (7.2 KB) - added by igmoweb 2 years ago.
28351-3.diff (49.2 KB) - added by igmoweb 2 years ago.
28351-4.diff (6.7 KB) - added by igmoweb 2 years ago.
28351~5.diff (7.8 KB) - added by UmeshSingla 2 years ago.
Updated docs for filters

Download all attachments as: .zip

Change History (17)

@UmeshSingla
3 years ago

Added filters to display a custom signup confirmation message for User or Blog registration

#2 @SergeyBiryukov
3 years ago

  • Focuses multisite added

#3 @UmeshSingla
3 years ago

Any Chance to see this coming in 4.0 Major release? It needs attention.

#4 @nacin
3 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Version changed from trunk to 3.0

@MikeHansenMe
3 years ago

Updated based on previous patch but pass the original message into the filter

#5 @MikeHansenMe
3 years ago

  • Keywords has-patch added

@igmoweb
2 years ago

#6 @igmoweb
2 years ago

Updated patch (28351-2.diff).

I've added three more filters to change the username, email and blog name texts.

I honestly think that wp-signup.php should be recoded to make it more extensible. gettext was suggested here: #27227 but I think is not the best way to customize it due to well-known performance issues when using that filter.

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

@igmoweb
2 years ago

#7 @igmoweb
2 years ago

Ugh, forget about 28351-2.diff. It included a change in unit tests. See 28351-3

@igmoweb
2 years ago

#8 @igmoweb
2 years ago

Ughx3!

Everything went crazy on my side, uploading 28351-4.diff.

#9 @MikeHansenMe
2 years ago

@since doc will need to be updated when this goes in.

#10 @DrewAPicture
2 years ago

  • Keywords needs-docs added

In addition to updating the @since versions, all three of the signup_*_text filters are missing hook documentation.

In the context those three filters are used, I would prefer to evaluate the filters to variables first then use the variables inline – the code will be cleaner and the lines will be shorter. Win/Win.

@UmeshSingla
2 years ago

Updated docs for filters

#11 @UmeshSingla
2 years ago

  • Keywords needs-docs removed
Note: See TracTickets for help on using tickets.