New filters in wp-activate.php

[UmeshSingla]

Added two new filters to filter content being displayed on activation confirmation or error.

signup_activation_success and signup_activation_error, it allows to change the default activation message being displayed

[UmeshSingla]

Added filters to display a custom user or blog activation message

[SergeyBiryukov]

Related: #17948, #20075.

[UmeshSingla]

Any Chance to see this coming in 4.0 Major release?

[MikeHansenMe]

Updated based on previous patch but pass the original message into the filter

[voldemortensen]

Conform to some doc block standards.

[boonebgorges]

A couple questions about the patch:

• Is there a way it can be restructured so we're not passing so much markup to the filters? The answer here may well be "no", but it would be nice to minimize it, since it makes the filter very difficult to use for any purpose but completely rebuilding the message.

• The two different kinds of string being filtered through 'signup_activation_error' are not similar at all. Only the second one seems like an error at all. Given the multiple different ways these messages can be built, I would lean toward having a single 'signup_activation_message' filter that everything gets passed through; callbacks can determine whether it's an "error" by looking at the $result parameter.

[flixos90]

An alternative approach would be short-circuiting the process of generating messages with a pre_signup_activation_error and pre_signup_activation_success. These could be passed a false (plus the other parameters) and if it returns anything other than that, do not continue.
Or we could be more specific and say if the filter returns a string, it is assumed to be a replacement message that we then print out before stopping.

[flixos90]

28352.4.diff​ is a new take on this ticket, aiming to simplify the process a bit.

• the code to print the success-/error-related output has been moved to separate functions signup_activation_error() and signup_activation_process()
• the filter pre_signup_activation_error can be used to short-circuit the process of generating the error output
• the filter pre_signup_activation_success can be used to short-circuit the process of generating the success output
• only $result is passed to those filters (in addition to empty string)

[jeremyfelt]

Let's push this off for this release. We need some more discussion on approach—replace individual messaging, short circuit entire page, do something entirely different?