Opened 12 years ago
Closed 12 years ago
#28373 closed enhancement (fixed)
edit_comment_link filter should pass the anchor text as a variable
| Reported by: | kwight | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.0 |
| Component: | Comments | Version: | 4.0 |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
The edit_comment_link filter currently passes only the comment ID as a variable. If a developer wants to assemble their own markup for the edit comment link, they'll need to somehow parse the anchor text from the entire $link variable. Passing the anchor text as a variable will solve this.
Attachments (3)
Change History (6)
#2
in reply to: ↑ 1
@
12 years ago
- Keywords has-patch commit added
- Milestone Awaiting Review → 4.0
28373.3.diff does the same for edit_post_link() and also updates filter docs.
Replying to kwight:
28373.2.diff can take it a step further and pass in the
$beforeand$aftervariables, bringing theedit_comment_linkfilter more in line with thecomment_reply_linkfilter.
That would make it less in line with edit_post_link filter :)
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
28373.2.diff can take it a step further and pass in the
$beforeand$aftervariables, bringing theedit_comment_linkfilter more in line with thecomment_reply_linkfilter.