WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#28389 closed defect (bug) (fixed)

Undo doesn't work properly after resizing an image several times

Reported by: azaozz's profile azaozz Owned by: azaozz's profile azaozz
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: has-patch
Focuses: Cc:

Description

Seems caused by the wpeditimage plugin. It changes the image tag after resizing that triggers another undo level.

Attachments (1)

28389.patch​ (375 bytes) - added by iseulde 11 years ago.

Download all attachments as: .zip

Change History (6)

#1 @azaozz
11 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 28614:

TinyMCE: fix problems with undo/redo after resizing an image several times. Fixes #28389.

#2 @azaozz
11 years ago

In 28615:

Regex should be non-greedy, see #28389

@iseulde
11 years ago

#3 @iseulde
11 years ago

  • Keywords has-patch added
  • Resolution fixed deleted
  • Status changed from closed to reopened

We should remove the margin from the toolbar since some themes add a margin on both sides of a p, causing the toolbar to be displayed a lot lower.

#4 @azaozz
11 years ago

We should remove the margin from the toolbar...

Right. In theory we can continue to use a <div> as the wrapper, however to be able to remove it easily with a regex, it shouldn't have any nested divs. Using a <p> implies no nested block tags.

#5 @azaozz
11 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 28624:

TinyMCE: remove margins from the image toolbar wrapper, props avryl, fixes #28389

Note: See TracTickets for help on using tickets.