WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#28397 closed defect (bug) (fixed)

Twenty Fourteen: Blog description cut

Reported by: pavelevap's profile pavelevap Owned by: lancewillett's profile lancewillett
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

For languages with characters like "Č", "Š", etc.

When there is "Č" in description, on the website is shown as "C".

Attachments (3)

Twenty_fourteen_description_cut.png​ (5.1 KB) - added by pavelevap 11 years ago.
28397.patch​ (405 bytes) - added by SergeyBiryukov 11 years ago.
28397.2.patch​ (400 bytes) - added by iamtakashi 11 years ago.

Download all attachments as: .zip

Change History (7)

@pavelevap
11 years ago

@SergeyBiryukov
11 years ago

#1 @SergeyBiryukov
11 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.0
  • Summary changed from Blog description cut in Twenty Fourteen to Twenty Fourteen: Blog description cut

Caused by a negative top margin for .site-description.

#2 @lancewillett
11 years ago

Thanks for the report and patch.

I'd like to run this by iamtakashi as it's in the original theme CSS (Further).

#3 @iamtakashi
11 years ago

This is caused by a combination of the negative top margin SergeyBiryukov pointed out and the z-index for #secondary.

The z-index value can't be larger than the value for .site-header because it's fixed position, and the negative top margin for .site-description was to make it line up with the bottom of the header but I didn't take account of accented characters. It's probably best to remove the negative top margin but we also need to compensate the 3 pixel from its bottom margin. Here is the updated patch.

@iamtakashi
11 years ago

#4 @lancewillett
11 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 28630:

Twenty Fourteen: adjust spacing for site description (tagline) to avoid cutting off accented characters. Props SergeyBiryukov, iamtakashi. Fixes #28397.

Note: See TracTickets for help on using tickets.