Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28400 closed enhancement (invalid)

Making if blocks more clear in customize.php

Reported by: bftrick's profile BFTrick Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.4
Component: Customize Keywords:
Focuses: Cc:

Description

In customize.php there are two separate if statements that check for opposite values right after one another. Instead of using two if statements we should use an if / else. It's far more clear.

Attachments (1)

customize.diff (511 bytes) - added by BFTrick 10 years ago.
customize.php diff

Download all attachments as: .zip

Change History (4)

@BFTrick
10 years ago

customize.php diff

#1 @SergeyBiryukov
10 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

In customize.php there are two separate if statements that check for opposite values right after one another.

That's not quite correct. The second statement also applies if wp_validate_redirect() returned an empty string.

#2 @SergeyBiryukov
10 years ago

  • Component changed from Administration to Appearance
  • Version changed from trunk to 3.4

#3 @BFTrick
10 years ago

Ah that makes sense now - thanks for the clarification! :)

Note: See TracTickets for help on using tickets.