Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#28400 closed enhancement (invalid)

Making if blocks more clear in customize.php

Reported by: BFTrick Owned by:
Priority: normal Milestone:
Component: Customize Version: 3.4
Severity: normal Keywords:
Cc: Focuses:

Description

In customize.php there are two separate if statements that check for opposite values right after one another. Instead of using two if statements we should use an if / else. It's far more clear.

Attachments (1)

customize.diff (511 bytes ) - added by BFTrick 12 years ago.
customize.php diff

Download all attachments as: .zip

Change History (4)

@BFTrick
12 years ago

customize.php diff

#1 @SergeyBiryukov
12 years ago

  • Milestone Awaiting Review
  • Resolutioninvalid
  • Status newclosed

In customize.php there are two separate if statements that check for opposite values right after one another.

That's not quite correct. The second statement also applies if wp_validate_redirect() returned an empty string.

#2 @SergeyBiryukov
12 years ago

  • Component AdministrationAppearance
  • Version trunk3.4

#3 @BFTrick
12 years ago

Ah that makes sense now - thanks for the clarification! :)

Note: See TracTickets for help on using tickets.