Redundant condition in WP_Query::get_posts()

[SergeyBiryukov]

This condition in WP_Query::get_posts()​ appears to be redundant:

if ( $this->is_comment_feed && ( $this->is_archive || $this->is_search || !$this->is_singular ) )

Unless I'm missing something, it could be simplified to:

if ( $this->is_comment_feed && ! $this->is_singular )

Introduced in [4934]. The change doesn't affect any of the current unit tests.

[engelen]

Syntax fix

[engelen]

(get-posts-redundant-condition.28401.diff: forgot to commit syntax change before diffing, get-posts-redundant-condition.28401-2.diff is the right diff)

I agree, this is a redundant check. is_archive and is_search can only be true if is_singular is false. Checking for ! is_singular is enough.

[SergeyBiryukov]

In 29257:

Remove a redundant condition for comment feeds from WP_Query::get_posts().

props engelen.
fixes #28401.