Twenty Fourteen - hardcoded pagination base

[pavelevap]

Twenty Fourteen does not support custom pagination base in twentyfourteen_paging_nav().

I tried following example, but links show "page" (and do not work):

function custom_pagination_base() {
  global $wp_rewrite;
  $wp_rewrite->pagination_base = 'stranka';
}
add_action( 'init', 'custom_pagination_base' );

I know I can change twentyfourteen_paging_nav() in child theme, but some users had problem with it (for example using simle plugin for custom permalinks in localized versions).

[pavelevap]

Thank you, Sergey! Works well. I tried many possibilities and different permalinks and no problem found using your patch!

[obenland]

Looks good. It would be nice if the globals could be documented in the function documentation on commit. Looks like we didn't do that initially.

[lancewillett]

Yes, let's add the documentation before commit, please. Want to refresh the patch?

[SergeyBiryukov]

28405.2.patch​ adds documentation for globals.

We should also probably add it for twentyfourteen_wp_title() in another ticket:
tags/3.9.1/src/wp-content/themes/twentyfourteen/functions.php#L460​

[lancewillett]

Replying to SergeyBiryukov:

28405.2.patch​ adds documentation for globals.

спасибо.

We should also probably add it for twentyfourteen_wp_title() in another ticket:
tags/3.9.1/src/wp-content/themes/twentyfourteen/functions.php#L460​

Added + patch in #28421.

[lancewillett]

Hmm, SVN commit didn't auto-close and add a comment here.

---

In [28645] Twenty Fourteen: change hardcoded pagination base to use the WordPress Rewrite object's pagination_base value instead. Document global variable usage properly.

Props SergeyBiryukov, fixes #28405.