Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 12 years ago

Closed 12 years ago

#28412 closed defect (bug) (fixed)

get_queried_object_id() method in pre_get_posts

Reported by:	wpsmith	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	4.0
Component:	Query	Version:	4.0
Severity:	normal	Keywords:	has-patch dev-feedback
Cc:		Focuses:

Description

When using $wp_query->get_queried_object_id() within the pre_get_posts hook results in an error:
Notice: Undefined property: WP_Query::$post in C:\xampp\htdocs\wp\wp-includes\query.php on line 3700

Here is a simple test:
https://gist.github.com/wpsmith/0c5a1d497eb5738309f6

Attachments (2)

28412.patch (661 bytes ) - added by wpsmith 12 years ago.: query.php patch
28412.diff (437 bytes ) - added by kovshenin 12 years ago.

Download all attachments as: .zip

Change History (7)

@wpsmith
12 years ago

Attachment 28412.patch added

query.php patch

#1 @wpsmith
12 years ago

Keywords has-patch dev-feedback added

This ticket was mentioned in IRC in #wordpress-dev by wpsmith. View the logs.

12 years ago

#3 @SergeyBiryukov
12 years ago

Focuses administration template multisite performance removed
Milestone Awaiting Review → 4.0

@kovshenin
12 years ago

Attachment 28412.diff added

#4 @kovshenin
12 years ago

An alternative approach in 28412.diff : since we're checking for null with is_null(), let's actually set it to null during init.

#5 @SergeyBiryukov
12 years ago

Owner set to SergeyBiryukov
Resolution → fixed
Status new → closed

Avoid a PHP notice when using WP_Query::get_queried_object() in pre_get_posts action.

props wpsmith.
fixes #28412.

Note: See TracTickets for help on using tickets.

Download in other formats: