WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#28414 closed enhancement (fixed)

Making videos responsive

Reported by: funkatronic's profile Funkatronic Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Media Keywords:
Focuses: Cc:

Description

I've found that embedded uploaded videos are responsive (resize depending on screen size ) in some themes (like WP's Twenty-series themes) and in others, not, like Highwind( ​https://wordpress.org/themes/highwind ). Patch will limit video inside content area and will make the video responsive.

Attachments (1)

wp-mediaelement.css.patch​ (389 bytes) - added by Funkatronic 11 years ago.
Patch to\wordpress-svn\wp-includes\js\mediaelement\wp-mediaelement.css

Download all attachments as: .zip

Change History (8)

@Funkatronic
11 years ago

Patch to\wordpress-svn\wp-includes\js\mediaelement\wp-mediaelement.css

#1 follow-up: @ericlewis
11 years ago

Was this not fixed in #26761?

#2 in reply to: ↑ 1 @Funkatronic
11 years ago

Replying to ericlewis:

Was this not fixed in #26761?

Looking at that ticket nothing was actually changed. I've switched themes around and I've found the bug triggered in a few of them. Please test with the theme I posted above.

Didn't see that last ticket, so I'm closing this one and adding the patch to previous ticket. Thanks for the catch

Version 1, edited 11 years ago by Funkatronic (previous) (next) (diff)

#3 @Funkatronic
11 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#4 @Funkatronic
11 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#5 @wonderboymusic
11 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from reopened to closed

In 28650:

In the spirit of [27622], add a few CSS rules to ensure that videos will be responsive, regardless of theme.

Props Funkatronic.
Fixes #28414.

#6 @wonderboymusic
11 years ago

  • Milestone changed from Awaiting Review to 4.0

#7 @Funkatronic
11 years ago

Awesome! Glad to contribute.

Note: See TracTickets for help on using tickets.