Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#28432 closed enhancement (wontfix)

Twenty Twelve: Remove obsolete hgroup

Reported by: artychan's profile artychan Owned by:
Milestone: Priority: normal
Severity: trivial Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

If you check the HTML5 specification or the HTML5 nightly, the hgroup element is no longer there. And according to the w3c validator, it's obsolete.

It would be great if we could update Twenty Twelve to no longer have hgroup, that'd be great. (It was done for Twenty Thirteen already in #24114 )

Change History (6)

#1 @lancewillett
10 years ago

  • Keywords close 2nd-opinion added

I vote not to change this.

Noting from Twenty Thirteen ticket notes: "I'm pretty sure we'd blow back compat if we'd attempt to remove it in older themes."

I agree with that, it'll break things in Twenty Twelve and older themes if we change this markup now -- authors could have styled it or written JavaScript that relies on that specific markup.

#2 @SergeyBiryukov
10 years ago

  • Summary changed from Twenty Twelve Update: Remove obsolete hgroup to Twenty Twelve: Remove obsolete hgroup

#3 @SergeyBiryukov
10 years ago

  • Type changed from defect (bug) to enhancement

#4 @obenland
10 years ago

  • Keywords close 2nd-opinion removed
  • Milestone Awaiting Review deleted
  • Severity changed from normal to trivial

Agreed. Since default themes are really popular parent themes — specifically Twenty Twelve — it's really difficult to make markup changes to them without possibly causing havoc in third party projects.

Additionally: In Twenty Thirteen and Twenty Fourteen we have a class in the element wrapping .site-title and .site-description which (hopefully) makes it more likely that developer use that rather than the element itself when writing a CSS selector, in Twenty Twelve that is unfortunately not the case.

#5 @SergeyBiryukov
10 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

#6 @artychan
10 years ago

yeah I realized after I posted that the header customization stuff is tied to the hgroup markup as well.

Thanks for the quick reply, and at least this ticket now exists for others to see.

Note: See TracTickets for help on using tickets.