Add 'fields' parameter to WP_Comment_Query

[mordauk]

The WP_Comment_Query class should support a fields argument, just like WP_Query does.

[mordauk]

Adds support for 'fields' parameter

[DrewAPicture]

+1

I'm surprised this has never been suggested before (at least, my searching yielded nothing).

[mordauk]

Basic unit tests added.

[SergeyBiryukov]

Related: #20487

[wonderboymusic]

28434.diff​ is more in line with how get_posts() works. Not sure that id=>parent should be comment_ID=>comment_post_ID. Seems like comment_parent might be more appropriate. Updated the unit tests as well, which didn't pass and didn't contain all new values for fields.

[nofearinc]

Related: #25386

[nacin]

Because id=>parent is ambiguous, I'd recommend id=>comment_parent and id=>post_parent, or something. For now, I'd suggest we drop it entirely.

[nacin]

In 29045:

WP_Comment_Query: Add fields => 'ids' query var.

props mordauk.
fixes #28434.

[nacin]

Reworked the tests to ensure we actually had integers. (If get_comments() returned objects and so did our factory create() method, this would have silently failed. Since our factory methods use core APIs under the hood, you never know.) Also used assertCount.

[mordauk]

Thanks nacin!

[SergeyBiryukov]

The test fails for me:

1) Tests_Comment_Query::test_fields_ids_query
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 2
+    0 => 4
     1 => 3
-    2 => 4
+    2 => 2
 )

S:\home\wordpress\develop\tests\phpunit\tests\comment\query.php:199

[SergeyBiryukov]

In 29134:

Use assertEqualSets() instead of direct array comparison.

see #28434.