grunt jshint for plugins and plugin developers

[MattyRob]

Grunt jshint can be used on core files and theme files (with the latter seeming limited to twenty fourteen at the moment).

I've extended my local Gruntfile.js to allow the plugins folder to be scanned and also implemented a 'folder' filter so a plugin folder name can be specified to be scanned.

This allows plugin developers easier access to JSHint and supports good coding standards. Is it worth adding to core?

[jorbin]

This looks like a good addition to me and one that will help plugin developers.

My only feedback is that I think the inline docs are a bit repetitive. I think the first line can have Optionally added to the start of it and it would be clearer.

[MattyRob]

Replying to jorbin:

This looks like a good addition to me and one that will help plugin developers.

My only feedback is that I think the inline docs are a bit repetitive. I think the first line can have Optionally added to the start of it and it would be clearer.

That's a good point - I'd just copied and pasted from the 'core' filename filter and through my edits made them the same! Update patch on the way.

[jorbin]

Looks good to me.

[wonderboymusic]

In 28798:

Add a grunt jshint:plugins task.

Props MattyRob.
Fixes #28464.

[nacin]

Let's call this dir or directory in lieu of folder.

[MattyRob]

As requested, use dir instead of folder. See new attached patch.

[netweb]

Two thoughts:

1) This task will only run JSHint on plugins being developed in \src\wp-content\plugins

• If a plugin developer needs, and I believe that they should, they should be running WordPress trunk from /build via the develop.svn repo or they should use core.svn to develop their plugin.

• Developing plugins by loading WordPress via \src\wp-content\plugins of the develop.svn repo excludes RTL CSS or admin themes CSS (Midnight, Ocean etc) and I think we should be encouraging plugin authors to test their plugins for compatibility with these core features.

2) The jshint:plugin task is now included by default in grunt precommit and grunt travis:js tasks

• It does not cause an error running either task though a warning is displayed (see image below)

• If not we should register a new task eg. jshint:corejs to call from grunt precommit and grunt travis:js so jshint:plugin is not included. eg 28464.corejs.diff

• 

[wonderboymusic]

In 28812:

Use dir instead of folder in the language for jshint:plugins

Props MattyRob.
See #28464.

[helen]

grunt precommit needs to not run this, please.

[MattyRob]

Replying to helen:

grunt precommit needs to not run this, please.

Isn't that covered in the patch submitted by netweb above?

[netweb]

Replying to MattyRob:

Replying to helen:

grunt precommit needs to not run this, please.

Isn't that covered in the patch submitted by netweb above?

Yes, 28464.corejs.diff​ excludes jshint:plugins from both grunt precommit and grunt travis:js tasks.

I'm not overly excited about the naming in that patch, it add's a task jshint:corejs because we already have jshint:core, I was thinking of switching the names of each of those tasks and there are both back compat pro's and con's for either. Happy for any other ideas or methods to implement this.

[helen]

Missed that part of the comment, carry on :)

[wonderboymusic]

In 28873:

Exclude jshint:plugins from both grunt precommit and grunt travis:js.

Props netweb.
Fixes #28464.