Opened 11 years ago
Closed 10 years ago
#28471 closed defect (bug) (fixed)
"quick edit" on a term replace the last one
Reported by: | juliobox | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Quick/Bulk Edit | Keywords: | has-patch needs-testing commit |
Focuses: | ui, javascript | Cc: |
Attachments (2)
Change History (13)
#2
@
11 years ago
I took a look here and realized that this issue is specific to the french translation. In the FR_fr translation the tag delimiter which is usually "," is instead ", " (with a space). inline-edit-post.js adds a space automatically to the delimiter so the french translation requires two spaces as delimiters. Here is a link to the translation in question.
It may also make sense to trim the delimiter in inline-edit-post.js to protect against issues like this in all translations.
#3
@
11 years ago
There is also a larger issue that the tag suggestion should allow the user to put a comma and no space to separate tags, while right now the space is required or the previous tag is replaced as above.
The suggest plugin needs to differentiate between the delimiter and the white space around it so that the white space is not required.
@
11 years ago
Patch for suggest and inline-edit-post to allow for tag suggestion with only delimiter and no whitespace.
@
11 years ago
Updated to trim tag delimiter to solve any localization that may add whitespace around the delimiter, removed whitespace option, and cleaned js code style.
#7
@
11 years ago
With that patch script-loader.php now should trip the delimiter so the change to the translation shouldn't be required and any other whitespace issues with the tag delimiter should also be resolved.
Reproduced with WP 3.9.1, and the trick is quite dumb.
If you put a comma and TWO spaces after your keyword, it will work properly. No spaces or only one space after the comma, and the last keyword will be replaced.
Nice catch.