Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #28473, comment 8


Ignore:
Timestamp:
08/03/2025 12:07:49 AM (6 months ago)
Author:
SirLouen
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28473, comment 8

    v1 v2  
    1111}}}
    1212
    13 Second, apart from this, I don't love that iterator. Instead of exploding the $headers first, and then running this, we could do both actions in the same run. I would have chosen a `foreach` because it's more visual
     13Second, apart from this, I don't love that iterator. Instead of exploding the $headers first, and then running this, we could do both actions in the same run. The for is Ok, but I would have chosen a `foreach` because it's easier to follow
    1414
    1515With this review, I'm looking forward to seeing those changes in code. The unit test refresh looks good.