WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#28485 closed enhancement (fixed)

All h3 tags in a metabox look like a handle

Reported by: nabil_kadimi Owned by: helen
Priority: normal Milestone: 4.0
Component: Administration Version: 4.0
Severity: normal Keywords: has-patch commit
Cc: Focuses: ui, administration

Description

When playing with metaboxes, I noticed that every h3 inside every metabox get this CSS applied to it:

.js .postbox h3 {
    cursor: move;
}

I believe only the first h3 child of .postbox would need that CSS, so a selector like this one would be more suited:

.js .postbox > h3 {
    ...

Attachments (3)

28485.patch​ (299 bytes ) - added by nabil_kadimi 12 years ago.
28485.2.patch​ (1.9 KB ) - added by SergeyBiryukov 12 years ago.
28485.3.patch​ (2.1 KB ) - added by SergeyBiryukov 12 years ago.

Download all attachments as: .zip

Change History (8)

@nabil_kadimi
12 years ago

#1 @SergeyBiryukov
12 years ago

  • Keywords has-patch commit added
  • Milestone Awaiting Review → 4.0

@SergeyBiryukov
12 years ago

#2 @SergeyBiryukov
12 years ago

Looks like this needs some more adjustments, see 28485.2.patch​.

We also use .hndle class in some places (example​). Perhaps we should use it in other instances too.

This ticket was mentioned in IRC in #wordpress-dev by SergeyBiryukov. ​View the logs.
12 years ago

This ticket was mentioned in IRC in #wordpress-dev by helen. ​View the logs.
12 years ago

@SergeyBiryukov
12 years ago

#5 @helen
12 years ago

  • Owner set to helen
  • Resolution → fixed
  • Status new → closed

In 28940:

Only apply metabox handle styles and JS events to .postbox .hndle, as opposed to all h3s in a .postbox.

Developers previously relying on the h3 behavior may be affected. You may want to investigate do_meta_boxes() rather than recreating markup.

props SergeyBiryukov, nabil_kadimi.
fixes #28485.

Note: See TracTickets for help on using tickets.