#28486 closed enhancement (fixed)
Base unit test does not have setExpectedDeprecated method
| Reported by: | rmccue | Owned by: | boonebgorges |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.2 |
| Component: | Build/Test Tools | Version: | 3.7 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
The @expectedDeprecated annotation was added in #25282, but does not have a method to accompany it.
This does not match the format used by PHPUnit, where @expectedException matches to setExpectedException().
We should add setExpectedDeprecated as a functional way to set this data.
Attachments (3)
Change History (14)
#5
@
12 years ago
Welcome @prasoon2211!
In 28486.diff, I don't think that it is necessary to have all of the add_action() calls. The actions will be hooked up by the expectDeprecated() method (called in setUp()). So maybe all you would need is the array_push() calls.
Also, it might be nice to add some tests for these methods in /tests/phpunit/tests/includes/helpers.php.
#7
@
12 years ago
@jdgrimes: Thanks for the input! 28486.3.diff has been attached. Let me know if there's anything more to be done.
#8
@
12 years ago
- Keywords has-patch added; needs-patch removed
28486.3.diff looks good. Now we just need to wait for someone with commit access to come along...
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
+1 makes sense to me.