Base unit test does not have setExpectedDeprecated method

[rmccue]

The @expectedDeprecated annotation was added in #25282, but does not have a method to accompany it.

This does not match the format used by PHPUnit, where @expectedException matches to setExpectedException().

We should add setExpectedDeprecated as a functional way to set this data.

[DrewAPicture]

+1 makes sense to me.

[boonebgorges]

Also setExpectedIncorrectUsage().

[prasoon2211]

Hey guys. New guy here :)

Anyway, I tried to make a patch (attached). Is it okay?

[jdgrimes]

Welcome @prasoon2211!

In 28486.diff​, I don't think that it is necessary to have all of the add_action() calls. The actions will be hooked up by the expectDeprecated() method (called in setUp()). So maybe all you would need is the array_push() calls.

Also, it might be nice to add some tests for these methods in /tests/phpunit/tests/includes/helpers.php.

[prasoon2211]

Version 2

[prasoon2211]

I forgot the test for the other method!

[prasoon2211]

Version 3

[prasoon2211]

@jdgrimes: Thanks for the input! 28486.3.diff has been attached. Let me know if there's anything more to be done.

[jdgrimes]

28486.3.diff​ looks good. Now we just need to wait for someone with commit access to come along...

[boonebgorges]

This is looking good. I'm going to write some docs and make the tests a little more verbose (they're currently a little tricky ;) )

[boonebgorges]

In 31306:

Introduce setExpectedDeprecated() and setExpectedIncorrectUsage() methods to `WP_UnitTestCase.

These methods provide a procedural alternative to the @expectedDeprecated
and @expectedIncorrectUsage test annotations, and parallel PHPUnit's native
setExpectedException().

Props prasoon2211, jdgrimes.
Fixes #28486.