WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28502, comment 5


Ignore:
Timestamp:
06/24/2014 02:52:34 AM (10 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #28502, comment 5

    initial v1  
    77$message = sprintf( _n( 'User deleted.', '%s users deleted.', $delete_count ), number_format_i18n( $delete_count ) );
    88}}}
    9 This doesn't seem like a valid use of `_n()`. `'User deleted.'` should be a separate string instead:
     9This doesn't seem like a valid use of `_n()`.
     10
     11It causes problems in Russian too. We have [https://glotpress.trac.wordpress.org/browser/trunk/locales/locales.php?rev=931#L1465 3 plural forms]. The first form is used not just for 1, but also for 21, 31, 41, etc. 'User deleted' only makes sense for 1. For 21, 31, etc., the number should be included in the string, but it's still the first form.
     12
     13I tried to address this previously in comment:12:ticket:15920 and on [http://make.wordpress.org/polyglots/2010/12/26/per-discussion-in-15920-ive-figured/ Polyglots], and ended up introducing a fourth plural form for Russian as a workaround. I managed to make it backwards compatible with the plural forms expression in GlotPress to import translations there (only the first three forms were imported), but still had to use Poedit to edit files and SVN to build packages.
     14
     15I think the correct solution here would be to review all these instances and separate single item strings from strings with numbers:
    1016{{{
    1117if ( $delete_count > 1 ) {
    … …  
    1521}
    1622}}}
    17 
    18 This causes problems in Russian too. We have [https://glotpress.trac.wordpress.org/browser/trunk/locales/locales.php?rev=931#L1465 3 plural forms]. The first form is used not just for 1, but also for 21, 31, 41, etc. 'User deleted' only makes sense for 1. For 21, 31, etc., the number should be included in the string, but it's still the first form.
    19 
    20 I tried to address this previously in comment:12:ticket:15920 and on [http://make.wordpress.org/polyglots/2010/12/26/per-discussion-in-15920-ive-figured/ Polyglots], and ended up introducing a fourth plural form for Russian as a workaround. I managed to make it backwards compatible with the plural forms expression in GlotPress to import translations there (only the first three forms were imported), but still had to use Poedit to edit files and SVN to build packages.
    21 
    22 I think the correct solution here would be to review all these instances and separate single item strings from strings with numbers.