WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#28529 closed defect (bug) (fixed)

Remove bulk action checkbox for Super Admin

Reported by: UmeshSingla Owned by: SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.9
Component: Users Keywords: has-patch commit
Focuses: administration, multisite Cc:

Description

The Bulk action checkbox serves no purpose for Super Admins in a multisite or admin in a normal site.

The only action allowed for Superadmin in a multisite is to mark it as not spam, which is doubtful in its place, Why should a spam user be allowed to get Superadmin privileges in first place?

I suggest to add a filter with default value as false to hide the bulk action checkbox for Superadmins or just not show it permanently without any filter.

If it is suppose to be considered, I can submit a patch

Attachments (2)

28529.png (34.4 KB) - added by jeremyfelt 6 years ago.
28529.1.diff (773 bytes) - added by bordoni 6 years ago.
Version 01

Download all attachments as: .zip

Change History (9)

#1 @Clorith
7 years ago

  • Focuses multisite added
  • Version changed from trunk to 3.9

Which screen are you referencing here that only has a mark as not spam option?

#2 @Clorith
7 years ago

  • Keywords reporter-feedback added

@jeremyfelt
6 years ago

#3 @jeremyfelt
6 years ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to Future Release

This makes sense. We do the same thing with a network's main site right now in the sites list table. If we aren't going to allow the action here, we can make it easier not to accidentally select it.

#4 @jeremyfelt
6 years ago

  • Milestone changed from Future Release to 4.4
  • Type changed from enhancement to defect (bug)

#5 @bordoni
6 years ago

  • Keywords has-patch dev-feedback added; needs-patch removed

I create a solution that removes the Checkbox, attached the .diff

PS: Not 100% sure if I should add dev-feedback, If I did it wrong, please let me know for the next time.

Last edited 6 years ago by bordoni (previous) (diff)

@bordoni
6 years ago

Version 01

#6 @SergeyBiryukov
6 years ago

  • Keywords commit added; dev-feedback removed

Looks good.

#7 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 33777:

Network Admin: Hide the bulk actions checkbox for super admins.

See [25125] for hiding the checkbox for the main site in Sites table.

props bordoni.
fixes #28529.

Note: See TracTickets for help on using tickets.