Opened 11 years ago
Closed 11 years ago
#28532 closed task (blessed) (fixed)
Add edit mode for MCE [embed] previews
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.0 | Priority: | normal |
Severity: | normal | Version: | 4.0 |
Component: | Embeds | Keywords: | has-patch |
Focuses: | javascript | Cc: |
Description
Wouldn't it be killer if you could edit your embeds like you edit other media previews?
Patch incoming.
Attachments (3)
Change History (11)
#3
@
11 years ago
I created a mixin so that embed
and embedURL
can share code. I highly suggest trying this feature out, it's pretty slick (pats self on back). Here are some URLs to test with:
http://www.youtube.com/watch?v=ssqvhobab_Q
https://soundcloud.com/disclosuremusic/frontin-pharrell-ft-jay-z-disclosure-re-work
#5
@
11 years ago
Getting Cannot read property 'edit' of undefined
when trying to edit a "plain URL" embed, pointing here: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/mce-view.js#L43
#6
@
11 years ago
type
and shortcode
mean different things, depending on whether it is a view
or view.View
. Some things need to refer to type
- done in 28532.3.diff
.2.diff accounts for the churn from avyrl's patch - both
[embed]
and URLs are supported for edit.