WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 7 months ago

#28533 closed enhancement (worksforme)

wpviews: style them differently

Reported by: iseulde Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.9
Component: TinyMCE Keywords:
Focuses: ui Cc:
PR Number:

Description

At the moment it's very difficult to see whether a view is selected when the content inside takes up the whole space. It might be better to use a dashed "outline" with an offset.

I would also move the buttons outside the view so they don't have to move for smaller views.

We could set the color of the dashed outline to the color of the text (with an opacity) so that it has a good contrast for all kind of backgrounds.

Screenshots and patch coming.

Attachments (8)

Screen Shot 2014-06-13 at 17.11.42.png (242.9 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-13 at 17.00.33.png (143.3 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-13 at 17.14.21.png (10.0 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-13 at 16.57.46.png (10.1 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-13 at 16.56.22.png (9.2 KB) - added by iseulde 6 years ago.
28533.patch (5.3 KB) - added by iseulde 6 years ago.
28533.2.patch (5.3 KB) - added by iseulde 6 years ago.
28533.3.patch (5.2 KB) - added by iseulde 6 years ago.

Download all attachments as: .zip

Change History (17)

@iseulde
6 years ago

@iseulde
6 years ago

@iseulde
6 years ago

#1 follow-up: @helen
6 years ago

I like this direction, but I'm just not a fan of centering the content in the editor like that. It's been throwing me off in the experiments on #28328 because I already have a set expectation based on how things have worked up until now. That isn't to say that we can't make changes, and my opinion is but one, but this feels bigger than one might think.

azaozz tried something in the past where the background color of the editor outside of the content area width was different and delineated, and centering the content area, like you'd see in a word processor. Doesn't solve the issue of reserving space for the toolbar if it's to the side though. That space also causes some horizontal scroll at narrower widths, which is the bane of my existence in text editing.

#2 @iseulde
6 years ago

I personally do like centring the content, because it feels less crammed. Most content in editors seems to be centred and the content in DFW is also centred. But that's also just my opinion. :)

That space also causes some horizontal scroll at narrower widths, which is the bane of my existence in text editing.

It shouldn't cause a horizontal scroll bar. With what theme and content did you test? Was it media overflowing?

#3 in reply to: ↑ 1 @SergeyBiryukov
6 years ago

Replying to helen:

azaozz tried something in the past where the background color of the editor outside of the content area width was different and delineated, and centering the content area, like you'd see in a word processor.

Related: #21536

#4 @iseulde
6 years ago

  • Milestone changed from Awaiting Review to 4.0

The least we could do here for 4.0 is adding some space between the border and the view.

#5 @iseulde
6 years ago

  • Keywords has-patch added

:before is used in the patch because outline-offset is not supported in IE. :(

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


6 years ago

#7 @helen
6 years ago

  • Milestone changed from 4.0 to Future Release
  • Type changed from defect (bug) to enhancement

No consensus yet, so punting from 4.0. Definitely want to keep refining this over time.

#8 @iseulde
5 years ago

  • Keywords needs-patch added; has-patch removed

The buttons have now changed, but the border/background could still be better.

Related: #28588.

#9 @azaozz
7 months ago

  • Keywords needs-patch removed
  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

That was a good idea, but... is now superseded by the block editor. The UI there looks much better :)

Note: See TracTickets for help on using tickets.