WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#28539 closed enhancement (duplicate)

Make more and nextpage tags beautiful (pure CSS) and translatable by converting them to wpviews

Reported by: iseulde Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords:
Focuses: ui Cc:
PR Number:

Description

Patch includes patch for #28533 to make it work.

Now they also display well against all kinds of backgrounds, and no visible pixels when you zoom in.

Attachments (6)

28539.patch (9.5 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-14 at 16.14.16.png (13.2 KB) - added by iseulde 6 years ago.
28539.2.patch (10.9 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-14 at 16.17.15.png (10.6 KB) - added by iseulde 6 years ago.
28539.3.patch (10.9 KB) - added by iseulde 6 years ago.
Screen Shot 2014-06-14 at 16.36.41.png (13.6 KB) - added by iseulde 6 years ago.

Download all attachments as: .zip

Change History (13)

@iseulde
6 years ago

@iseulde
6 years ago

#1 @iseulde
6 years ago

Added after and before screenshots with exactly the same content and theme.

#2 @iseulde
6 years ago

The color for the dashed borders depends on the color of the body's color rule.

@iseulde
6 years ago

#3 @iseulde
6 years ago

I wish we had a __() function in JS. :) We should probably split mce-view.js before localising it...

#4 follow-up: @azaozz
5 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release

Not sure converting to wpViews is the best thing for these. Changing the placeholders from <img> to <hr> seems better. Then we can still use "more advanced" CSS, but keep things simple.

#5 in reply to: ↑ 4 @afercia
5 years ago

Replying to azaozz:

Changing the placeholders from <img> to <hr> seems better. Then we can still use "more advanced" CSS, but keep things simple.

I'm playing a bit with this and tried many things, including <hr> and <table>, but I always end up with something a bit hacky and not so future-proof.
Mr. Ozz, any objections to use TinyMCE noneditable plugin? Looks like it handles selection, caret position, dragging, delete, backspace and it would allow to use a normal inline element + CSS generated content instead of a void or replaced element where generated content is not guaranteed to work.

#6 @iseulde
5 years ago

#28539 was marked as a duplicate.

#7 @iseulde
5 years ago

  • Keywords needs-patch removed
  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

I forgot we still had this ticket. Let's use #29804 now.

Note: See TracTickets for help on using tickets.