Twenty Fourteen: Header should not be fixed on wp-signup.php or wp-activate.php

[SergeyBiryukov]

If you visit wp-signup.php or wp-activate.php as a logged in user of the network, you'll see an empty space above the header, which only disappears if you remove the .masthead-fixed class from <body>.

See the screenshots.

[lancewillett]

Thanks for the report.

[slobodanmanic]

I really don't like the fact this has to use $pagenow and specifically check for these two pages, but can't think of cleaner way, as far as I know there are no conditional tags for these pages.

[slobodanmanic]

I really don't like the fact this has to use $pagenow and specifically check for these two pages, but can't think of cleaner way, as far as I know there are no conditional tags for these pages.

P.S. Attachment descriptions are not meant to be used with long comments :)

[obenland]

Solution looks good.

slobodanmanic, could you refresh your patch from the trunk/ directory, so it can be applied cleanly? I think we can also merge the else statement with the new if clause to an elseif.

[slobodanmanic]

Absolutely, great point on elseif.

[slobodanmanic]

28573-3.diff moves comment to docblock

[lancewillett]

In 29100:

Twenty Fourteen: fix header display on multisite signup and activate views. Fixes #28573, props slobodanmanic.