Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#28573 closed defect (bug) (fixed)

Twenty Fourteen: Header should not be fixed on wp-signup.php or wp-activate.php

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: lancewillett's profile lancewillett
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch needs-refresh
Focuses: Cc:

Description (last modified by SergeyBiryukov)

If you visit wp-signup.php or wp-activate.php as a logged in user of the network, you'll see an empty space above the header, which only disappears if you remove the .masthead-fixed class from <body>.

See the screenshots.

Attachments (5)

28573.wp-signup.png (60.3 KB) - added by SergeyBiryukov 12 years ago.
28573.wp-activate.png (21.5 KB) - added by SergeyBiryukov 12 years ago.
28573.diff (526 bytes) - added by slobodanmanic 12 years ago.
I really don't like the fact this has to use $pagenow and specifically check for these two pages, but can't think of cleaner way, as far as I know there are no conditional tags for these pages.
28573-2.diff (536 bytes) - added by slobodanmanic 12 years ago.
28573-3.diff (770 bytes) - added by slobodanmanic 12 years ago.

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
12 years ago

  • Description modified (diff)

#2 @lancewillett
12 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.0

Thanks for the report.

@slobodanmanic
12 years ago

I really don't like the fact this has to use $pagenow and specifically check for these two pages, but can't think of cleaner way, as far as I know there are no conditional tags for these pages.

#3 @slobodanmanic
12 years ago

I really don't like the fact this has to use $pagenow and specifically check for these two pages, but can't think of cleaner way, as far as I know there are no conditional tags for these pages.

P.S. Attachment descriptions are not meant to be used with long comments :)

#4 @obenland
12 years ago

  • Keywords has-patch needs-refresh added; needs-patch removed

Solution looks good.

slobodanmanic, could you refresh your patch from the trunk/ directory, so it can be applied cleanly? I think we can also merge the else statement with the new if clause to an elseif.

#5 @slobodanmanic
12 years ago

Absolutely, great point on elseif.

This ticket was mentioned in IRC in #wordpress-themes by obenland. View the logs.


12 years ago

#7 @slobodanmanic
12 years ago

28573-3.diff moves comment to docblock

#8 @lancewillett
12 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 29100:

Twenty Fourteen: fix header display on multisite signup and activate views. Fixes #28573, props slobodanmanic.

Note: See TracTickets for help on using tickets.