WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#28585 closed enhancement (fixed)

Disable Autocomplete on DB setup-config.php

Reported by: hebbet Owned by: johnbillion
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.9.1
Component: Upgrade/Install Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Currently that suggests other database Passwords, when setting up yet another wordpress blog.

In my opinion that textfield should either changed to a type="password" or autocomplete="off" should be added.

Will add patches for both asap.

Attachments (2)

setup-config.php.patch​ (726 bytes) - added by hebbet 5 years ago.
patch for autocomplete off
setup-config-2.php.patch​ (711 bytes) - added by hebbet 5 years ago.
patch for password input with type password

Download all attachments as: .zip

Change History (7)

@hebbet
5 years ago

patch for autocomplete off

@hebbet
5 years ago

patch for password input with type password

#1 @hebbet
5 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
5 years ago

  • Component changed from Administration to Upgrade/Install
  • Milestone changed from Awaiting Review to 4.0

type="password" is a wontfix, see #3534, #5529, #22443, #25630.

autocomplete="off" makes sense to me.

#3 @SergeyBiryukov
5 years ago

Should we perhaps disable autocomplete for the whole form?

#4 @johnbillion
5 years ago

I think setup-config.php.patch​ is fine. Autocomplete is handy for the other fields on this form.

#5 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 29032:

Remove autocomplete from the database password screen on setup-config.php. Props hebbet. Fixes #28585.

Note: See TracTickets for help on using tickets.