WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#28587 closed defect (bug) (fixed)

Installed theme search doesn't show a "No themes found" message

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.0 Priority: normal
Severity: normal Version: 3.8
Component: Themes Keywords: has-patch commit
Focuses: ui, administration Cc:

Description

If your search for an installed theme doesn't produce any results, you'll just get a blank screen (see the screenshot). There should be a "No themes found" message.

This was a regression in 3.8.

Attachments (5)

28587.png​ (48.5 KB) - added by SergeyBiryukov 9 years ago.
28587.patch​ (1.5 KB) - added by gauravmittal1995 9 years ago.
Displays the Not found message.
28587.2.png​ (53.2 KB) - added by gauravmittal1995 9 years ago.
Screenshot for patch
28587.2.patch​ (933 bytes) - added by SergeyBiryukov 9 years ago.
28587.2.after.png​ (50.2 KB) - added by SergeyBiryukov 9 years ago.

Download all attachments as: .zip

Change History (9)

@SergeyBiryukov
9 years ago

#1 @SergeyBiryukov
9 years ago

  • Focuses ui added

@gauravmittal1995
9 years ago

Displays the Not found message.

#2 @gauravmittal1995
9 years ago

  • Keywords has-patch added; needs-patch removed

Added the patch for displaying the "No Themes Found". Also will add screenshot.

@gauravmittal1995
9 years ago

Screenshot for patch

@SergeyBiryukov
9 years ago

@SergeyBiryukov
9 years ago

#3 @SergeyBiryukov
9 years ago

  • Keywords commit added; good-first-bug removed
  • Milestone changed from Awaiting Review to 4.0

28587.2.patch​ takes the same approach we have on Add Themes screen.

#4 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 28890:

Show a "No themes found" message if the search for an installed theme doesn't produce any results.

props gauravmittal1995 for initial patch.
fixes #28587.

Note: See TracTickets for help on using tickets.