Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#28597 closed enhancement (fixed)

Add oEmbed support for Speaker Deck

Reported by: mt_suzette's profile mt_Suzette Owned by: johnbillion's profile johnbillion
Milestone: 4.4 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch commit
Focuses: Cc:

Description

This is a follow-up to #21635.
It's been two years since this ticket was closed and there is still not support for speakerdeck oEmbeds. Can this be added?

Attachments (2)

28597.diff (793 bytes) - added by hlashbrooke 9 years ago.
First pass - seems pretty straightforward, but willing to accept if the regex isn't bulletproof..
28597-1.diff (1.1 KB) - added by hlashbrooke 9 years ago.
Updating patch to include Speaker Deck in commented list of available oEmbed providers

Download all attachments as: .zip

Change History (13)

#1 @SergeyBiryukov
10 years ago

  • Summary changed from Can speakerdeck support be added now? Ref #21635. to Add oEmbed support for Speaker Deck
  • Type changed from feature request to enhancement

#2 @johnbillion
10 years ago

  • Keywords close added
  • Milestone changed from Awaiting Review to 4.0

Thanks for the report mt_Suzette. I'm moving this to 4.0 for consideration, although personally I do not think we should add support for Speaker Deck.

As per Sergey's link above, there are certain considerations that need to be made when deciding whether to add support for an oEmbed provider. It mainly boils down to popularity, trust, and establishment.

Speaker Deck is not a particularly popular service, and certainly isn't mainstream. It doesn't have a WikiPedia page, and it has just ~600 Twitter followers (with ten tweets in the last year). Even a search on Google for "speaker deck" only returns ~300,000 results.

Speaker Deck's parent company was acquired by GitHub in 2011, and one of their other services, Guages, was recently sold on. While GitHub is an established and trustworthy service, it doesn't appear that Speaker Deck gets much love. This brings into question whether we can trust Speaker Deck to stick around.

I'll leave this in the 4.0 milestone for now, but suggesting as wontfix. There is a Speaker Deck Embed plugin that can be used to embed slides from Speaker Deck.

#3 @johnbillion
10 years ago

  • Milestone 4.0 deleted
  • Resolution set to maybelater
  • Status changed from new to closed

I'm going to close this off again. Speaker Deck just isn't popular enough, and its trust and establishment aren't set in stone either. The Speaker Deck Embed plugin is available to those who want to embed slides from Speaker Deck.

#4 @rmccue
9 years ago

  • Keywords close removed
  • Resolution maybelater deleted
  • Status changed from closed to reopened

Reopening for consideration. Speaker Deck is used quite a bit, and it's definitely a stable service at this point that GitHub continues to maintain. It's not quite as popular as Slideshare for sure, but we do have wordpress.tv embeds, which have a similar audience.

(FWIW, WordPress.com also supports Speaker Deck, as an added vote of confidence.)

#5 @johnbillion
9 years ago

  • Keywords needs-patch added
  • Milestone set to 4.4
  • Version 3.9.1 deleted

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


9 years ago

@hlashbrooke
9 years ago

First pass - seems pretty straightforward, but willing to accept if the regex isn't bulletproof..

@hlashbrooke
9 years ago

Updating patch to include Speaker Deck in commented list of available oEmbed providers

#7 @hlashbrooke
9 years ago

  • Keywords has-patch added; needs-patch removed

#8 @johnbillion
9 years ago

  • Owner set to johnbillion
  • Status changed from reopened to reviewing

This ticket was mentioned in Slack in #core by wonderboymusic. View the logs.


9 years ago

#10 @johnbillion
9 years ago

  • Keywords commit added

All the tests in #32360 pass when testing with https://speakerdeck.com/mattwiebe/power-your-portfolio-with-wordpress.

#11 @johnbillion
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 35693:

Add support for oEmbeds from Speaker Deck.

Fixes #28597

Note: See TracTickets for help on using tickets.