WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28599, comment 119


Ignore:
Timestamp:
01/09/2021 09:57:57 PM (4 months ago)
Author:
ryelle
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28599, comment 119

    initial v1  
    1 Resurrecting this old ticket, since as far as I can tell the approach is still valid, but it stalled out from lack of screenshots. The patch doesn't apply anymore, so I grabbed the basic idea of it and made [attachment:"28599.diff" a new patch]. This new patch adds a 4px box shadow to hover and focus, plus adding a spacer between the side of the submenu "flyout". Thanks to `currentColor` and transparent borders, we don't actually need to change the color scheme sass base, it behaves correctly in all schemes.
     1Resurrecting this old ticket, since as far as I can tell the approach is still valid, but it stalled out from lack of screenshots. The patch doesn't apply anymore, so I grabbed the basic idea of it and made [attachment:"28599.diff" a new patch]. This new patch adds a 4px border (box shadow) to hover and focus, plus adding a spacer between the side of the submenu "flyout". Thanks to `currentColor` and transparent borders, we don't actually need to change the color scheme sass base, it behaves correctly in all schemes.
    22
    33So, screenshots. I have plenty of those: https://cloudup.com/cdWzjq0yvuq