WordPress.org

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #28599, comment 29


Ignore:
Timestamp:
11/12/2014 06:23:09 PM (6 years ago)
Author:
usability.idealist
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28599, comment 29

    v1 v2  
    1 Replying to [comment:28 afercia]:
    2 
    3 > I agree with @helen that design-wise, what @michaelarestad proposed is better than an outline. Besides accessibility considerations, I see a couple of potential issues with the border on the left, see screenshot below, it's just a quick in-browser editing, please don't focus on colors:
    4 
    5 dito. maybe using a variation of my initial "bracketing" - ie. adding a left and right border, high-contrast - would work better? Not sure if people will actually recognize the border as a visual focus inside the submenu.
    6 
    7 > - shifting the item text on the right could break the text in 2 lines just when focused; we can't predict the item text length and having a line of text that breaks in 2 lines when focused looks pretty bad
    8 
    9 The line-break already happens as soon as you use non-english languages. Last week I wrote a plugin as part of a job and added i18n - I always use English for i18n reasons, no matter that it aint my native language - and as soon as the German translation was in, several menu items broke into two lines.
    10 
    11 Which I do '''not''' consider as an issue. As long as the actual submenu works, and does not act up like it did right after HoverIntent made it into the Admin Menu, all is well.
    12 
    13 cu, w0lf.
    14 
    15 ps: Afterthought: Gonna check out a few variations, including above said left-right-border scheme, and add em here ;)
     1.