Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#28608 closed defect (bug) (fixed)

Improve padding of toolbar submenu items on small screens

Reported by: tillkruess's profile tillkruess Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.9.2
Component: Toolbar Keywords: has-patch ui-feedback
Focuses: ui Cc:

Description

The padding of toolbar submenu items is IMO quite un-equal, little top padding, large bottom padding. See screenshot.

The normal toolbar (>768px) also adds a top/button padding to sub menus itself, that might be worth porting to the mobile toolbar, so the sub-menu are have a clearer separation.

Attachments (3)

28608.patch (454 bytes) - added by tillkruess 10 years ago.
padding.jpg (75.4 KB) - added by tillkruess 10 years ago.
28608.2.patch (432 bytes) - added by dots 10 years ago.
Please find the attached patch file.

Download all attachments as: .zip

Change History (8)

@tillkruess
10 years ago

@tillkruess
10 years ago

@dots
10 years ago

Please find the attached patch file.

#1 @dots
10 years ago

  • Keywords has-patch added

#2 @tellyworth
10 years ago

  • Keywords ui-feedback added
  • Version changed from trunk to 3.9.2

#3 @morganestes
9 years ago

Tested the first patch by @tillkruess and it looks good.
I'm not sure what benefit patch 2 provides; I can't see any difference with it applied.

#4 @wonderboymusic
9 years ago

  • Milestone changed from Awaiting Review to 4.4

we can look at this

#5 @SergeyBiryukov
9 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 35132:

Toolbar: Improve padding of toolbar submenu items on small screens.

Props tillkruess.
Fixes #28608.

Note: See TracTickets for help on using tickets.