WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28625, comment 2


Ignore:
Timestamp:
06/28/14 01:52:35 (3 years ago)
Author:
andrewbevitt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28625, comment 2

    initial v1  
    1 I agree this should be included. But, the patch shouldn't silently drop the certificate file if the file does not exist. This would allow the connection to be opened without SSL which the MySQL server may allow.  
     1I agree this should be included. But, the patch shouldn't silently drop the certificate file if the file does not exist. This would allow the connection to be opened without SSL; assuming the MySQL server allows that.  
    22 
    33It would be better to pass the parameter as given, and allow the mysqli_real_connect call to fail. This seems to be the intended idea, as the PHP docs for mysqli_ssl_set indicate it always returns TRUE (http://www.php.net/manual/en/mysqli.ssl-set.php).