WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #28633, comment 52


Ignore:
Timestamp:
09/23/2015 04:14:15 AM (4 years ago)
Author:
dd32
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #28633, comment 52

    initial v1  
    66 - streamlined the `try {} catch {} catch {}` to avoid needing to use version comparisons
    77
    8 The only issue I noted in the compat library, is that PHP7's `random_int()` claims to accept Integers, but accepts numeric types (floats/numeric strings) happily, and it appears that `wp_rand()` probably does too. As such, https://github.com/paragonie/random_compat/compare/master...dd32:compat-types?expand=1 is my work-in-progress at allowing it.
     8The only issue I noted in the compat library, is that PHP7's `random_int()` claims to accept Integers, but accepts numeric types (floats/numeric strings) happily, and it appears that `wp_rand()` probably does too. ''edit: this is patched in https://github.com/paragonie/random_compat/pull/36''
    99
    1010I was delayed in testing this thanks to conferences & the PHP7 packages being delayed (I'm testing using [https://webtatic.com/news/tag/php/ Webtatic PHP7 packages] for Centos/RHEL 6 (In case anyone wants to also verify my experience)