WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#28638 closed defect (bug) (fixed)

Update wpautop() Unit Tests to handle changes for figcaption, option, and select

Reported by: rachelbaker Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: Formatting Keywords: has-patch needs-testing wpautop
Focuses: Cc:

Description

In #25646 figcaption and in #22230 option and select tags were removed from the wpautop block level elements. The related unit test from #25856 need a minor adjustment to account for the changes and pass as expected.

1) Tests_Formatting_Autop::test_that_wpautop_treats_block_level_elements_as_blocks
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 <pre>foo</pre>
-<select>foo</select>
-<option>foo</option>
+<p><select>foo</select></p>
+<p><option>foo</option></p>

@@ @@
 <figure>foo</figure>
-<figcaption>foo</figcaption>
+<p><figcaption>foo</figcaption></p>
 <details>foo</details>
 <menu>foo</menu>
 <summary>foo</summary>'

Attachments (1)

28638.patch (617 bytes) - added by rachelbaker 7 years ago.
updated autop unit tests

Download all attachments as: .zip

Change History (5)

@rachelbaker
7 years ago

updated autop unit tests

#1 @rachelbaker
7 years ago

  • Keywords has-patch needs-testing added

#2 @rachelbaker
7 years ago

  • Keywords wpautop added

#3 @wonderboymusic
7 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 28853:

Fix wpautop() unit tests. See #25646, #22230, #25856.

Props rachelbaker.
Fixes #28638.

#4 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.0
Note: See TracTickets for help on using tickets.