Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#28640 closed defect (bug) (fixed)

Enable selecting multiple files when uploading from mobile devices

Reported by: azaozz's profile azaozz Owned by:
Milestone: 4.0 Priority: normal
Severity: normal Version:
Component: Upload Keywords: dev-feedback
Focuses: Cc:

Description

Earlier versions of iOS (Safari) didn't support selecting multiple files. This is still not supported in the current Android (KitKat) browser, see https://code.google.com/p/chromium/issues/detail?id=348912.

Attachments (1)

28640.patch (2.5 KB) - added by azaozz 11 years ago.

Download all attachments as: .zip

Change History (7)

#1 @azaozz
11 years ago

In 28847:

Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640.

@azaozz
11 years ago

#2 @azaozz
11 years ago

The current implementation in iOS is still lacking, the limitation for using the camera as source still hasn't been fixed. When the multiple attribute on <input type="file"> is present, the users can only select existing files. Without it the users can either select a file or use the camera as source (to take a snapshot or video which is uploaded directly).

From UX point of view being able to upload multiple files has (much?) higher priority than selecting the camera as source.

28640.patch is a (hacky) attempt to work around that limitation (only for Media->Add New). It adds a second button in iOS and dynamically resets the multi_selection Plupload setting. Not sure if we should try doing that or leave as-is for now. There is also a chance that this limitation will be finally fixed in iOS8.

#3 follow-up: @DrewAPicture
11 years ago

  • Keywords dev-feedback added

@azaozz: What's left here? Is 28640.patch something you'd endorse for commit or shall we regroup in 4.1?

This ticket was mentioned in IRC in #wordpress-dev by DrewAPicture. View the logs.


11 years ago

This ticket was mentioned in IRC in #wordpress-dev by ocean90. View the logs.


11 years ago

#6 in reply to: ↑ 3 @azaozz
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to DrewAPicture:

Thinking this is working well at the moment. If we want to add another button for iOS to select the camera as a source for the upload, we will need a better way to distinguish the shims that are used by Plupload. Currently there's no way to tell which shim corresponds to which button.

This may also be fixed in the next iOS. There is no good reason why selecting multiple files and selecting the camera as a source don't work for the same <input type="file"...>.

Last edited 11 years ago by azaozz (previous) (diff)
Note: See TracTickets for help on using tickets.