WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#28647 closed defect (bug) (fixed)

Radio and Checkboxs within form-field class are being stretched

Reported by: mauteri Owned by: wonderboymusic
Milestone: 4.0 Priority: normal
Severity: normal Version: 4.0
Component: General Keywords: has-patch
Focuses: ui, administration Cc:

Description

Since .form-field input is set to width: 95% in the admin css, radio and checkboxes get distorted.

Attachments (6)

28647.diff (378 bytes) - added by mauteri 7 years ago.
CSS patch
Screen Shot 2014-06-26 at 1.23.18 PM.png (11.0 KB) - added by mauteri 7 years ago.
Screenshot of issue
28647.2.diff (358 bytes) - added by wonderboymusic 7 years ago.
28647.3.diff (552 bytes) - added by mauteri 7 years ago.
Covers a bit more including text, password, email, number, search, tel, and url
28647.4.diff (618 bytes) - added by kovshenin 7 years ago.
28647.5.diff (2.2 KB) - added by ocean90 7 years ago.

Download all attachments as: .zip

Change History (16)

@mauteri
7 years ago

CSS patch

@mauteri
7 years ago

Screenshot of issue

#1 @wonderboymusic
7 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.0

#2 @wonderboymusic
7 years ago

The rules in forms.css are correct, but edit.css overwrites them. Depending on how specific the rules are, this can cause the described behavior.

#3 @wonderboymusic
7 years ago

28647.2.diff might be a safer bet.

@mauteri
7 years ago

Covers a bit more including text, password, email, number, search, tel, and url

#4 @helen
7 years ago

#28452 was marked as a duplicate.

#5 @wonderboymusic
7 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 29292:

Whitelist input types that are styled in the scope of .form-field.

Props mauteri.
Fixes #28647.

@kovshenin
7 years ago

#6 @kovshenin
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Should we do the same for compat fields? See 28647.4.diff.

#7 @mauteri
7 years ago

Absolutely, good catch.

#8 @ocean90
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29360:

Media: Don't stretch radio and checkbox inputs in compat fields. Adjust margin for radio inputs.

props kovshenin for initial patch.
fixes #28647.

#9 @kovshenin
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@ocean90 in r29360 you removed the width, so .media-sidebar .setting input[type="checkbox"] now inherits the width from .media-sidebar .setting input which is 65%. Here's what the gallery settings screen now looks like: https://cloudup.com/c6Vpg41uXYf

@ocean90
7 years ago

#10 @wonderboymusic
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 29441:

After [29360], add rules for <input>s in the scope of .media-sidebar.

Props ocean90.
Fixes #28647.

Note: See TracTickets for help on using tickets.